Review ResponseStatus usage #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a mapping between PKCS 11 and TSS error codes with our ResponseStatus. Adds a conversion between String and ResponseStatus in the Key ID Manager. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
ionut-arm
reviewed
Feb 6, 2020
| let psa_status = psa_status.checked_add(PSA_STATUS_TO_RESPONSE_STATUS_OFFSET)?; | ||
| let psa_status = u16::try_from(psa_status).ok()?; | ||
| Some(psa_status.try_into().ok()?) | ||
| let psa_status = match psa_status.checked_abs() { |
There was a problem hiding this comment.
.checked_abs().ok_or(ResponseStatus::InvalidEncoding)? - does this work? Same for the ones below
There was a problem hiding this comment.
I tried something like that but it does not unfortunately! The reason is that the function returns ResponseStatus and not Option<ResponseStatus>
ionut-arm
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mapping between PKCS 11 and TSS error codes with our
ResponseStatus.
Adds a conversion between String and ResponseStatus in the Key ID
Manager.
Signed-off-by: Hugues de Valon hugues.devalon@arm.com
Close #77
Close #72